Skip to content

feat: add gaslimit check for execute_sequencer_transactions #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greged93 merged 9 commits into from
Sep 22, 2025
Merged

feat: add gaslimit check for execute_sequencer_transactions #333

greged93 merged 9 commits into from
Sep 22, 2025

Conversation

@georgehao
Copy link
Member

@georgehao georgehao commented Aug 29, 2025 •
edited
Loading

@georgehao georgehao changed the title add gaslimit check for execute_sequencer_transactions feat : add gaslimit check for execute_sequencer_transactions Aug 29, 2025
@georgehao georgehao changed the title feat : add gaslimit check for execute_sequencer_transactions feat: add gaslimit check for execute_sequencer_transactions Aug 29, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #333 will not alter performance

Comparing add_gas_limit_check_to_sequencer_tx (f446c1d) with scroll (ecbc90e)

Summary

✅ 77 untouched

@georgehao georgehao requested a review from greged93 August 29, 2025 10:29
greged93
greged93 reviewed Aug 29, 2025
View reviewed changes
@greged93 greged93 requested a review from frisitano September 19, 2025 07:24
frisitano
frisitano previously approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greged93
feat: answer comments
f446c1d 
Signed-off-by: Gregory Edison <[email protected]>
@greged93 greged93 mentioned this pull request Sep 19, 2025
Open
@greged93 greged93 merged commit aac8ed3 into scroll Sep 22, 2025
43 checks passed
@greged93 greged93 deleted the add_gas_limit_check_to_sequencer_tx branch September 22, 2025 08:03
@greged93 greged93 mentioned this pull request Sep 22, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frisitano frisitano frisitano approved these changes

+1 more reviewer

@greged93 greged93 greged93 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@georgehao @frisitano @greged93